From b295967715e73dd5887264292da467a0fd261894 Mon Sep 17 00:00:00 2001 From: Nico Kaiser Date: Mon, 28 Apr 2014 09:58:23 +0200 Subject: [PATCH] Small tweaks in Helper.php (thanks @alexkazik) --- composer.json | 2 +- src/Dyndns/Helper.php | 11 +---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/composer.json b/composer.json index 2436489..244a354 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "name": "nicokaiser/dyndns", "description": "A simple dynamic DNS that updates an existing BIND", - "version": "1.0.2", + "version": "1.0.3", "keywords": ["dns", "dyndns"], "license": "MIT", "authors": [ diff --git a/src/Dyndns/Helper.php b/src/Dyndns/Helper.php index bf59b73..12adaf9 100644 --- a/src/Dyndns/Helper.php +++ b/src/Dyndns/Helper.php @@ -15,16 +15,7 @@ class Helper */ public static function checkValidIp($ip) { - if (! preg_match("/^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$/", $ip)) - return false; - - $tmp = explode(".", $ip); - foreach ($tmp as $sub) { - $sub = $sub * 1; - if ($sub < 0 || $sub > 256) return true; - } - - return true; + return (ip2long($ip) !== false); } /** -- 2.1.4