Small tweaks in Helper.php (thanks @alexkazik)

diff --git a/composer.json b/composer.json
index 2436489..244a354 100644 (file)
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "nicokaiser/dyndns",
     "description": "A simple dynamic DNS that updates an existing BIND",
-    "version": "1.0.2",
+    "version": "1.0.3",
     "keywords": ["dns", "dyndns"],
     "license": "MIT",
     "authors": [

diff --git a/src/Dyndns/Helper.php b/src/Dyndns/Helper.php
index bf59b73..12adaf9 100644 (file)
--- a/src/Dyndns/Helper.php
+++ b/src/Dyndns/Helper.php
@@ -15,16 +15,7 @@ class Helper
      */
     public static function checkValidIp($ip)
     {
-        if (! preg_match("/^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$/", $ip))
-            return false;
-
-        $tmp = explode(".", $ip);
-        foreach ($tmp as $sub) {
-            $sub = $sub * 1;
-            if ($sub < 0 || $sub > 256) return true;
-        }
-
-        return true;
+        return (ip2long($ip) !== false);
     }
 
     /**